Use fontc as alternative gftools.builder compiler #1046
Conversation
| @@ -131,9 +143,24 @@ def validate(self): | |||
|
|
|||
|
|
|||
| class FontmakeOperationBase(OperationBase): | |||
| COMPILER_ENV_KEY = "GFTOOLS_COMPILER" | |||
There was a problem hiding this comment.
couldn't we just have a different subclass of OperationBase, and switch to that dynamically? then we'd avoid junking up this class with fontc stuff, and I could properly handle the arguments...
There was a problem hiding this comment.
If you believe it would be cleaner, I would be happy to see it.
There was a problem hiding this comment.
The only part I'm not sure about is how best to swap the classes in the presence of the CLI flag. Do you have any ideas?
There was a problem hiding this comment.
Nope, not really. Once a class is loaded in Python it's unpleasant to try to change its base class. This is why I suggested doing things the way that I did ...
There was a problem hiding this comment.
I'm not following why we'd need to change base, we should have two different classes and pick which one to create based on cli. I don't know the gftools codebase, is there something about it that makes that difficult?
There was a problem hiding this comment.
If you're not changing base class, then you will need six different classes (one implementation each of buildTTF, buildOTF, buildVariable for fontc and fontbakery). This is less elegant than the solution I'm proposing.
There was a problem hiding this comment.
I think I would dispute the elegance of writing if self.compiler == :)
Implements #1045, if you set
GFTOOLS_COMPILER=fontcenvironment variable. Some caveats:argsthat invoke--filterare dropped on the floor. Ideally these should be converted, ie.--filter FlattenComponentsFiltershould become--flatten-components, etc.instantiateUFO->buildTTFpipelines won't quite work yet as we assume JSON UFO structures in instantiated UFOs, whichfontcdoesn't support. Maybe we could make the JSON-ness dependent onFontmakeOperationBase.compiler != "fontc".